Add serde support for tl_types. #277
Conversation
|
Related issue #276 |
|
Whoops, generated code seems encount some issue. |
RuofengX
changed the title
|
Can you revert the formatting change to the .toml files out of this PR? |
I tried to add serde code only in Then I add my fork of I not formillar with build system, but I am looking into it.
Sure, I will write cfg(feature="serde") in |
|
Behavior nowUser can fetch any raw struct (defined by FlawStructure in Example |
RuofengX
changed the title
|
We need more test and docs about this new feature. |
| #[derive(Clone, Debug, PartialEq)] | ||
| pub struct Blob(pub Vec<u8>); | ||
| pub struct Blob(#[cfg_attr(feature = "impl-serde", serde(with = "serde_bytes"))] pub Vec<u8>); |
There was a problem hiding this comment.
Help needed.
I am not formiliar with tl proto. Is there any other structure that store bytes in .tl definition files? All bytes-like properties need marked by serde_bytes for better performence.
There was a problem hiding this comment.
Yes, Vec<u8> are also generated for the TL bytes type. If that's the case, we may need to check the field types when generating code.
Might be good to write a test that makes sure this works as expected.
| @@ -37,6 +37,10 @@ fn write_enum<W: Write>( | |||
| writeln!(file, "{indent}#[derive(Debug)]")?; | |||
| } | |||
|
|
|||
| if config.impl_serde{ | |||
There was a problem hiding this comment.
Formatting is going to complain here.
| @@ -63,6 +63,10 @@ fn write_struct<W: Write>( | |||
| writeln!(file, "{indent}#[derive(Debug)]")?; | |||
| } | |||
|
|
|||
| if config.impl_serde{ | |||
Add two lines for each entrance in generated.rs
(Did I miss for other things?)
Pass all tests in crate
grammers-tl-types