Skip to content

🐛 wrong tests for older laravel versions #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 12, 2023
Merged

🐛 wrong tests for older laravel versions #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d2df2fc
:arrow_up: updated postgres in test
GautierDele Nov 12, 2023
5df2005
:bug: laravel downgrade for tests
GautierDele Nov 12, 2023
4287f7a
:arrow_up: Laravel 10.0+
GautierDele Nov 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
fail-fast: false
matrix:
php-version: [ '8.1', '8.2' ]
laravel-version: [ '^8.0', '^9.0', '^10.0' ]
laravel-version: [ '^10.0' ]
database: [ 'sqlite', 'mysql', 'pgsql' ]

name: Tests on PHP ${{ matrix.php-version }} with Laravel ${{ matrix.laravel-version }} and ${{ matrix.database }}
Expand All @@ -31,7 +31,7 @@ jobs:
options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3

pgsql:
image: postgres:10.8
image: postgres:16
env:
POSTGRES_USER: postgres
POSTGRES_PASSWORD: postgres
Expand Down Expand Up @@ -64,7 +64,7 @@ jobs:

- name: Install dependencies
if: steps.composer-cache.outputs.cache-hit != 'true'
run: composer update --with "illuminate/contracts=${{ matrix.laravel-version }}" --prefer-dist --no-progress
run: composer require laravel/framework:${{ matrix.laravel-version }} -W --prefer-dist --no-progress

- name: Run test suite with Sqlite
if: matrix.database == 'sqlite'
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Laravel Rest Api is an elegant way to expose your app through an API, it takes f

## Requirements

PHP 8.1+ and Laravel 8.0+
PHP 8.1+ and Laravel 10.0+

## Documentation, Installation, and Usage Instructions

Expand Down
8 changes: 4 additions & 4 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,14 @@
"require": {
"php": "^8.0",
"ext-json": "*",
"illuminate/contracts": "^8.37|^9.0|^10.0",
"illuminate/http": "^8.37|^9.0|^10.0",
"illuminate/support": "^8.37|^9.0|^10.0"
"illuminate/contracts": "^10.0",
"illuminate/http": "^10.0",
"illuminate/support": "^10.0"
},
"require-dev": {
"guzzlehttp/guzzle": "^6.0|^7.0",
"orchestra/testbench": "^8.5",
"phpunit/phpunit": "^6.0|^7.0|^8.0|^9.0|^10.0"
"phpunit/phpunit": "^8.0|^9.0|^10.0"
},
"autoload": {
"psr-4": {
Expand Down