Skip to content

✨ renames detail to details #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2023
Merged

✨ renames detail to details #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Concerns/PerformsRestOperations.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ trait PerformsRestOperations
*
* @return array
*/
public function detail(DetailRequest $request)
public function details(DetailRequest $request)
{
$request->resource($resource = static::newResource());

Expand Down
8 changes: 4 additions & 4 deletions src/Http/Routing/ResourceRegistrar.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ class ResourceRegistrar extends BaseResourceRegistrar
*
* @var string[]
*/
protected $resourceDefaults = ['detail', 'search', 'mutate', 'operate', 'destroy', 'restore', 'forceDelete'];
protected $resourceDefaults = ['details', 'search', 'mutate', 'operate', 'destroy', 'restore', 'forceDelete'];

/**
* The verbs used in the resource URIs.
Expand All @@ -29,7 +29,7 @@ class ResourceRegistrar extends BaseResourceRegistrar
];

/**
* Add the detail method for a resourceful route.
* Add the details method for a resourceful route.
*
* @param string $name
* @param string $base
Expand All @@ -38,13 +38,13 @@ class ResourceRegistrar extends BaseResourceRegistrar
*
* @return \Illuminate\Routing\Route
*/
protected function addResourceDetail($name, $base, $controller, $options)
protected function addResourceDetails($name, $base, $controller, $options)
{
$uri = $this->getResourceUri($name);

unset($options['missing']);

$action = $this->getResourceAction($name, $controller, 'detail', $options);
$action = $this->getResourceAction($name, $controller, 'details', $options);

return $this->router->get($uri, $action);
}
Expand Down