Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/Http/Requests/DestroyRequest.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

namespace Lomkit\Rest\Http\Requests;

use Illuminate\Validation\Rule;
use Lomkit\Rest\Http\Resource;

class DestroyRequest extends RestRequest
Expand Down Expand Up @@ -32,10 +33,16 @@ public function rules()
*/
public function destroyRules(Resource $resource)
{
$model = $resource::newModel();

return [
'resources' => [
'required', 'array',
],
'resources.*' => [
'distinct',
Rule::exists($model->getTable(), $model->getKeyName()),
],
];
}
}
22 changes: 22 additions & 0 deletions tests/Feature/Controllers/DeleteOperationsTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,28 @@ public function test_deleting_a_non_authorized_model_with_an_authorized_one(): v
$this->assertDatabaseHas('models', $modelDeletable->only('id'));
}

public function test_deleting_a_non_existing_model(): void
{
$model = ModelFactory::new()->count(1)->createOne();

Gate::policy(Model::class, GreenPolicy::class);

$response = $this->delete(
'/api/models',
[
'resources' => [
999999,
$model->getKey(),
],
],
['Accept' => 'application/json']
);

$response->assertStatus(422);
$response->assertExactJsonStructure(['message', 'errors' => ['resources.0']]);
$this->assertDatabaseHas('models', $model->only('id'));
}

public function test_deleting_a_model(): void
{
$model = ModelFactory::new()->count(1)->createOne();
Expand Down