Skip to content

Conversation

@ThanhSonITNIC
Copy link
Contributor

No description provided.

	modified:   config/rest.php
	modified:   src/Concerns/Resource/ConfiguresRestParameters.php
	modified:   src/Rules/SearchRules.php
@ThanhSonITNIC
Copy link
Contributor Author

Hello @GautierDele
Can you review this pull reuqest asap

@GautierDele
Copy link
Member

Ok, in a few hours

@GautierDele
Copy link
Member

@ThanhSonITNIC i implemented lazy validation which will make things faster and also removed the nested depth option, if this is something you consider useful, please open a new PR so we can consider this separately 😄

@GautierDele GautierDele merged commit bc82057 into Lomkit:master Jan 23, 2024
@ThanhSonITNIC
Copy link
Contributor Author

$fieldRelation = $this->relation(Str::before($field, '.'));
return $fieldRelation->resource()->isNestedField(Str::after($field, '.'), $fieldRelation);

I got error 500 Call to a member function resource() on null in line 60 when relation not defined in resource

@GautierDele
Copy link
Member

Ok i'll fix it, shouldn't be hard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants