OSOE-925: Upgrade to Orchard Core 3.0 and .NET 10#1211
OSOE-925: Upgrade to Orchard Core 3.0 and .NET 10#1211sarahelsaig wants to merge 293 commits intodevfrom
Conversation
|
This pull request has merge conflicts. Please resolve those before requesting a review. |
(assuming upstream OC fix, to be submitted)
|
This pull request has merge conflicts. Please resolve those before requesting a review. |
|
This pull request has merge conflicts. Please resolve those before requesting a review. |
|
This pull request has merge conflicts. Please resolve those before requesting a review. |
# Conflicts: # src/Modules/Lombiq.Walkthroughs
|
This pull request has merge conflicts. Please resolve those before requesting a review. |
| "rules": { | ||
| "unique-landmark": "off" | ||
| "unique-landmark": "off", | ||
| "attribute-allowed-values": "off" |
There was a problem hiding this comment.
This is necessary because the violation comes from Shepherd itself so it can't be helped.
There was a problem hiding this comment.
I fixed this in dev a while ago with a separate WalkthroughsShouldWorkCorrectly.htmlvalidate.json config, please merge that.
There was a problem hiding this comment.
It seems like that only applies to the main solution and not to NuGetTests. What should I do? Copy it over to NuGetTests as well?
There was a problem hiding this comment.
Can't actually these tests reference those files? I mean, the code in the tests. It's not like this solution is independent form the root one.
|
This pull request has merge conflicts. Please resolve those before requesting a review. |
3 participants
OSOE-925
Fixes #894