Skip to content

Conversation

@Lokejoke
Copy link
Owner

@Lokejoke Lokejoke commented Nov 15, 2024

Summary

This PR implements getter-without-return-value.
Catches 'get_' starting functions returning no value or None.

Test Plan

cargo test

@Lokejoke Lokejoke changed the title Getter without return value [wps-light] Implement getter-without-return-value (WPS463) Nov 16, 2024
@Lokejoke Lokejoke marked this pull request as ready for review November 16, 2024 17:18
@github-actions
Copy link

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+13 -0 violations, +0 -0 fixes in 3 projects; 51 projects unchanged)

apache/airflow (+7 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

+ airflow/auth/managers/base_auth_manager.py:121:5: WPS463 Getter function returns no value.
+ airflow/auth/managers/base_auth_manager.py:443:5: WPS463 Getter function returns no value.
+ airflow/models/taskinstance.py:3246:5: WPS463 Getter function returns no value.
+ airflow/secrets/base_secrets.py:93:5: WPS463 Getter function returns no value.
+ providers/src/airflow/providers/mysql/hooks/mysql.py:351:5: WPS463 Getter function returns no value.
+ providers/tests/common/sql/operators/test_sql.py:61:5: WPS463 Getter function returns no value.
+ tests/www/views/test_views_extra_links.py:61:5: WPS463 Getter function returns no value.

apache/superset (+3 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

+ superset/db_engine_specs/base.py:2144:5: WPS463 Getter function returns no value.
+ superset/db_engine_specs/base.py:667:5: WPS463 Getter function returns no value.
+ superset/db_engine_specs/base.py:685:5: WPS463 Getter function returns no value.

bokeh/bokeh (+3 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

+ src/bokeh/server/auth_provider.py:253:5: WPS463 Getter function returns no value.
+ src/bokeh/server/auth_provider.py:257:5: WPS463 Getter function returns no value.
+ src/bokeh/server/auth_provider.py:265:5: WPS463 Getter function returns no value.

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
WPS463 13 13 0 0 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants