Skip to content

Conversation

@Lokejoke
Copy link
Owner

Summary

This PR implements reserved-argument-as-variable.
Checks for abuse of a "reserved" first argument name.

Test Plan

cargo test

@github-actions
Copy link

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+83 -0 violations, +0 -0 fixes in 4 projects; 50 projects unchanged)

apache/airflow (+49 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

+ airflow/exceptions.py:141:9: WPS117 Reserved argument name cls used as variable
+ airflow/exceptions.py:242:9: WPS117 Reserved argument name cls used as variable
+ airflow/exceptions.py:405:9: WPS117 Reserved argument name cls used as variable
+ airflow/exceptions.py:47:9: WPS117 Reserved argument name cls used as variable
+ airflow/exceptions.py:83:9: WPS117 Reserved argument name cls used as variable
+ airflow/io/utils/stat.py:36:30: WPS117 Reserved argument name self used as variable
+ airflow/io/utils/stat.py:39:31: WPS117 Reserved argument name self used as variable
+ airflow/io/utils/stat.py:42:30: WPS117 Reserved argument name self used as variable
+ airflow/io/utils/stat.py:45:30: WPS117 Reserved argument name self used as variable
+ airflow/io/utils/stat.py:48:30: WPS117 Reserved argument name self used as variable
+ airflow/io/utils/stat.py:51:32: WPS117 Reserved argument name self used as variable
+ airflow/models/baseoperator.py:163:34: WPS117 Reserved argument name cls used as variable
+ airflow/providers_manager.py:161:5: WPS117 Reserved argument name cls used as variable
+ airflow/providers_manager.py:171:5: WPS117 Reserved argument name cls used as variable
+ airflow/providers_manager.py:479:13: WPS117 Reserved argument name cls used as variable
+ airflow/serialization/serde.py:136:5: WPS117 Reserved argument name cls used as variable
+ airflow/serialization/serde.py:234:5: WPS117 Reserved argument name cls used as variable
+ airflow/serialization/serde.py:240:9: WPS117 Reserved argument name cls used as variable
+ airflow/serialization/serde.py:260:5: WPS117 Reserved argument name cls used as variable
+ airflow/task/priority_strategy.py:121:25: WPS117 Reserved argument name cls used as variable
+ airflow/utils/module_loading.py:52:5: WPS117 Reserved argument name cls used as variable
+ airflow/utils/module_loading.py:55:9: WPS117 Reserved argument name cls used as variable
+ providers/src/airflow/providers/alibaba/cloud/hooks/oss.py:44:9: WPS117 Reserved argument name self used as variable
+ providers/src/airflow/providers/amazon/aws/hooks/s3.py:120:17: WPS117 Reserved argument name self used as variable
+ providers/src/airflow/providers/amazon/aws/hooks/s3.py:90:13: WPS117 Reserved argument name self used as variable
+ providers/src/airflow/providers/dbt/cloud/hooks/dbt.py:156:13: WPS117 Reserved argument name self used as variable
+ providers/src/airflow/providers/dbt/cloud/hooks/dbt.py:62:13: WPS117 Reserved argument name self used as variable
+ providers/src/airflow/providers/microsoft/azure/hooks/data_factory.py:1092:17: WPS117 Reserved argument name self used as variable
+ providers/src/airflow/providers/microsoft/azure/hooks/data_factory.py:94:17: WPS117 Reserved argument name self used as variable
... 20 additional changes omitted for project

apache/superset (+5 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

+ superset/models/helpers.py:389:9: WPS117 Reserved argument name cls used as variable
+ superset/utils/json.py:192:5: WPS117 Reserved argument name cls used as variable
+ tests/integration_tests/base_tests.py:266:29: WPS117 Reserved argument name cls used as variable
+ tests/unit_tests/utils/cache_test.py:32:34: WPS117 Reserved argument name self used as variable
+ tests/unit_tests/utils/cache_test.py:34:5: WPS117 Reserved argument name self used as variable

bokeh/bokeh (+28 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

+ src/bokeh/command/bootstrap.py:102:9: WPS117 Reserved argument name cls used as variable
+ src/bokeh/core/has_props.py:146:19: WPS117 Reserved argument name cls used as variable
+ src/bokeh/core/has_props.py:154:22: WPS117 Reserved argument name cls used as variable
+ src/bokeh/core/property/bases.py:205:30: WPS117 Reserved argument name cls used as variable
+ src/bokeh/core/property/bases.py:557:54: WPS117 Reserved argument name cls used as variable
+ src/bokeh/core/property/dataspec.py:490:29: WPS117 Reserved argument name cls used as variable
+ src/bokeh/core/property/dataspec.py:505:29: WPS117 Reserved argument name cls used as variable
+ src/bokeh/core/property/dataspec.py:519:29: WPS117 Reserved argument name cls used as variable
+ src/bokeh/core/property/dataspec.py:588:29: WPS117 Reserved argument name cls used as variable
+ src/bokeh/core/property/descriptors.py:179:29: WPS117 Reserved argument name cls used as variable
+ src/bokeh/core/property/descriptors.py:351:29: WPS117 Reserved argument name cls used as variable
+ src/bokeh/core/serialization.py:344:9: WPS117 Reserved argument name cls used as variable
+ src/bokeh/core/serialization.py:688:9: WPS117 Reserved argument name cls used as variable
+ src/bokeh/core/serialization.py:712:9: WPS117 Reserved argument name cls used as variable
+ src/bokeh/embed/bundle.py:453:47: WPS117 Reserved argument name cls used as variable
+ src/bokeh/embed/bundle.py:457:47: WPS117 Reserved argument name cls used as variable
... 12 additional changes omitted for project

zulip/zulip (+1 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

+ zerver/tests/test_service_bot_system.py:430:9: WPS117 Reserved argument name self used as variable

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
WPS117 83 83 0 0 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants