Skip to content

Conversation

@Lokejoke
Copy link
Owner

@Lokejoke Lokejoke commented Nov 17, 2024

Summary

This PR implements rule underscores-in-number.
It addressed one style of numeric formatting,
that is no underscores in number literals.

Test Plan

cargo test

Related issues

@github-actions
Copy link

github-actions bot commented Nov 17, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+11 -0 violations, +0 -0 fixes in 3 projects; 51 projects unchanged)

apache/airflow (+9 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

+ airflow/models/taskinstance.py:3703:23: WPS303 [*] Found underscores in number literal `1_000_000`
+ providers/src/airflow/providers/amazon/aws/utils/__init__.py:58:40: WPS303 [*] Found underscores in number literal `1_000`
+ providers/src/airflow/providers/amazon/aws/utils/__init__.py:63:69: WPS303 [*] Found underscores in number literal `1_000`
+ providers/src/airflow/providers/amazon/aws/utils/__init__.py:68:40: WPS303 [*] Found underscores in number literal `1_000_000`
+ providers/src/airflow/providers/google/cloud/example_dags/example_presto_to_gcs.py:129:36: WPS303 [*] Found underscores in number literal `10_000_000`
+ providers/tests/amazon/aws/utils/test_utils.py:33:9: WPS303 [*] Found underscores in number literal `946_684_800`
+ providers/tests/amazon/aws/utils/test_utils.py:49:48: WPS303 [*] Found underscores in number literal `1_000_000`
+ providers/tests/system/google/cloud/gcs/example_trino_to_gcs.py:148:36: WPS303 [*] Found underscores in number literal `10_000_000`
+ tests/cli/commands/test_webserver_command.py:176:55: WPS303 [*] Found underscores in number literal `4_000_000`

apache/superset (+1 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

+ superset/migrations/shared/catalogs.py:127:72: WPS303 [*] Found underscores in number literal `1_000_000`

bokeh/bokeh (+1 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

+ src/bokeh/models/widgets/sliders.py:361:24: WPS303 [*] Found underscores in number literal `3_600_000`

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
WPS303 11 11 0 0 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants