Skip to content

Release (Fix) #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Release (Fix) #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f155dc
FIx: Eventhub Managed Identity api connection object was broken
Splaxi Nov 19, 2024
94a298f
Merge pull request #79 from Splaxi/impl-eventhub
Splaxi Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 1 addition & 19 deletions PsLogicAppExtractor/internal/tasks/All/All.task.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -767,7 +767,7 @@ Task -Name "Set-Arm.Connections.ManagedApis.Eventhub.ManagedIdentity.AsArmObject
$tools = Get-PSFConfigValue -FullName PsLogicAppExtractor.Execution.Tools

$found = $false
$conType = "servicebus"
$conType = "eventhubs"

$armObj = Get-TaskWorkObject

Expand Down Expand Up @@ -821,24 +821,6 @@ Task -Name "Set-Arm.Connections.ManagedApis.Eventhub.ManagedIdentity.AsArmObject
$apiObj.properties.displayName = "[parameters('$parmApicId')]"
$apiObj.properties.parameterValueSet.values.namespaceEndpoint.value = $apiObj.properties.parameterValueSet.values.namespaceEndpoint.value.Replace("'##NAMESPACE##'", "parameters('$parmApicNamespace')")

# $idPreSuf = Format-Name -Type "Connection" -Value "$($connectionObj.Name)"
# $nsPreSuf = Format-Name -Type "Connection" -Prefix $Prefix -Suffix "_Namespace" -Value "$($connectionObj.Name)"

# $armObj = Add-ArmParameter -InputObject $armObj -Name "$nsPreSuf" `
# -Type "string" `
# -Value "$resName" `
# -Description "The name of the servicebus namespace. ($($connectionObj.Name))"

# $armObj = Add-ArmParameter -InputObject $armObj -Name "$idPreSuf" `
# -Type "string" `
# -Value $conName `
# -Description "The name / id of the ManagedApi connection object that is being utilized by the Logic App. Will be for the trigger and other actions that depend on connections."

# # Update the api object properties
# $apiObj.Name = "[parameters('$idPreSuf')]"
# $apiObj.properties.displayName = "[parameters('$idPreSuf')]"
# $apiObj.properties.parameterValueSet.values.namespaceEndpoint.value = $apiObj.properties.parameterValueSet.values.namespaceEndpoint.value.Replace("'##NAMESPACE##'", "parameters('$nsPreSuf')")

# Append the new resource to the ARM template
$armObj.resources += $apiObj

Expand Down
20 changes: 1 addition & 19 deletions ...ernal/tasks/Set-Arm.Connections.ManagedApis.Eventhub.ManagedIdentity.AsArmObject.task.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Task -Name "Set-Arm.Connections.ManagedApis.Eventhub.ManagedIdentity.AsArmObject
$tools = Get-PSFConfigValue -FullName PsLogicAppExtractor.Execution.Tools

$found = $false
$conType = "servicebus"
$conType = "eventhubs"

$armObj = Get-TaskWorkObject

Expand Down Expand Up @@ -73,24 +73,6 @@ Task -Name "Set-Arm.Connections.ManagedApis.Eventhub.ManagedIdentity.AsArmObject
$apiObj.properties.displayName = "[parameters('$parmApicId')]"
$apiObj.properties.parameterValueSet.values.namespaceEndpoint.value = $apiObj.properties.parameterValueSet.values.namespaceEndpoint.value.Replace("'##NAMESPACE##'", "parameters('$parmApicNamespace')")

# $idPreSuf = Format-Name -Type "Connection" -Value "$($connectionObj.Name)"
# $nsPreSuf = Format-Name -Type "Connection" -Prefix $Prefix -Suffix "_Namespace" -Value "$($connectionObj.Name)"

# $armObj = Add-ArmParameter -InputObject $armObj -Name "$nsPreSuf" `
# -Type "string" `
# -Value "$resName" `
# -Description "The name of the servicebus namespace. ($($connectionObj.Name))"

# $armObj = Add-ArmParameter -InputObject $armObj -Name "$idPreSuf" `
# -Type "string" `
# -Value $conName `
# -Description "The name / id of the ManagedApi connection object that is being utilized by the Logic App. Will be for the trigger and other actions that depend on connections."

# # Update the api object properties
# $apiObj.Name = "[parameters('$idPreSuf')]"
# $apiObj.properties.displayName = "[parameters('$idPreSuf')]"
# $apiObj.properties.parameterValueSet.values.namespaceEndpoint.value = $apiObj.properties.parameterValueSet.values.namespaceEndpoint.value.Replace("'##NAMESPACE##'", "parameters('$nsPreSuf')")

# Append the new resource to the ARM template
$armObj.resources += $apiObj

Expand Down
Loading