feat: backend dropdown for /query view #3093
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msmithstubbs
force-pushed
the
feat/query-clickhouse-backend
branch
from
78fe512 to
54cf2f0
Compare
msmithstubbs
commented
Jan 19, 2026
msmithstubbs
commented
Jan 19, 2026
msmithstubbs
commented
Jan 19, 2026
msmithstubbs
force-pushed
the
feat/query-clickhouse-backend
branch
2 times, most recently
from
4ab1b8c to
ab3be59
Compare
msmithstubbs
changed the title
Ziinc
reviewed
Jan 27, 2026
Comment on lines
171
to
175
| expect(ClickHouseAdaptor, :execute_query, fn _backend, query, _opts -> | ||
| assert {~S|SELECT now() AS "my_time"|, _, _, %{language: :ch_sql}} = query | ||
|
|
||
| {:ok, [%{"my_time" => "123"}]} | ||
| end) |
Contributor
There was a problem hiding this comment.
shouldn't stub if can, ideally we run it against the test CH backend with test setup for it.
| test "?sql= with backend_id uses backend's language", %{conn: conn, user: user} do | ||
| backend = insert(:backend, user: user, type: :clickhouse) | ||
|
|
||
| expect(ClickHouseAdaptor, :execute_query, fn _backend, query, _opts -> |
lib/logflare/endpoints.ex
Outdated
| @spec validate_backend_sources(Query.t(), Backend.t(), String.t()) :: :ok | {:error, String.t()} | ||
| defp validate_backend_sources(%Query{backend_id: nil}, _backend, _query_string), do: :ok | ||
|
|
||
| defp validate_backend_sources( |
Contributor
There was a problem hiding this comment.
i think instead of validating, since this can become quite complex, we just let the error propagate to the user as an error message, either as a flash or an alert (which might be more readable).
if a table doesn't exist then it should be quite self-explanatory that something is not configured right.
Contributor
Author
There was a problem hiding this comment.
Removed, and query run error is now rendered under the form.
Ziinc
requested changes
Jan 27, 2026
Contributor
Ziinc
left a comment
Ziinc
left a comment
There was a problem hiding this comment.
overall changes look good, just hesitant on the validation logic, looks very heavy for what we need.
msmithstubbs
force-pushed
the
feat/query-clickhouse-backend
branch
from
d7ef484 to
1220945
Compare
Just pass backend adaptor error to UI.
msmithstubbs
force-pushed
the
feat/query-clickhouse-backend
branch
from
1220945 to
ed361c0
Compare
msmithstubbs
commented
Jan 28, 2026
| {"lib/logflare_web/controllers/stripe_controller.ex", :pattern_match_cov}, | ||
| {"lib/logflare_web/live/billingaccount_live/payment_method_component.ex", :call}, | ||
| {"lib/logflare_web/live/monaco_editor_component.ex", :pattern_match}, | ||
| {"lib/logflare_web/live/endpoints/endpoints_live.ex", :unused_fun}, |
Contributor
Author
There was a problem hiding this comment.
Added to get test typings to pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows users to select which backend to run a query again.
/api/queryaccept an optionalbackend_id.backend_idandsqlparams are used the sql dialect will be inferred from the selected backend.ch_sql,pg_sql, orbq_sqlparam this determines the sql dialect used.Error messages
An backend error from running a query is rendered in the UI under the form. Format is slightly different depending on how the backend returns errors: