Support RequestAwareGRpcMetricsTagsContributor on Multiary Calls #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jGleitz
commented
Sep 14, 2021
| /** | ||
| * Prefer overriding {@link #getTags(Object, MethodDescriptor, Attributes, Tags)}. | ||
| */ | ||
| @Deprecated |
There was a problem hiding this comment.
The idea behind marking this @Deprecated is that it’s easier if clients all use the same method. This method could then be removed in the next major release.
On the other hand, it’s also not much effort to keep supporting this method, so we can also remove @Deprecated.
jGleitz
force-pushed
the
multiary-metrics
branch
from
beb19b9 to
4729c30
Compare
jGleitz
force-pushed
the
multiary-metrics
branch
from
4729c30 to
3963d9f
Compare
jGleitz
commented
Sep 14, 2021
...main/java/org/lognet/springboot/grpc/autoconfigure/metrics/GRpcMetricsAutoConfiguration.java
Show resolved
Hide resolved
jGleitz
commented
Sep 14, 2021
...main/java/org/lognet/springboot/grpc/autoconfigure/metrics/GRpcMetricsAutoConfiguration.java
Show resolved
Hide resolved
jGleitz
commented
Sep 14, 2021
| private final Collection<GRpcMetricsTagsContributor> tagsContributors; | ||
| @Getter | ||
| private Tags additionalTags = Tags.empty(); | ||
| private volatile boolean closed = false; |
There was a problem hiding this comment.
volatile is sufficient here, since there will be no parallel access.
jGleitz
commented
Sep 14, 2021
...main/java/org/lognet/springboot/grpc/autoconfigure/metrics/GRpcMetricsAutoConfiguration.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #245 +/- ##
============================================
- Coverage 90.64% 90.49% -0.16%
- Complexity 214 219 +5
============================================
Files 38 38
Lines 930 957 +27
Branches 40 44 +4
============================================
+ Hits 843 866 +23
- Misses 68 69 +1
- Partials 19 22 +3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #244
… and also refactor the metric code a bit.