Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with reactive-grpc and the default security interceptors #355

Closed
sheinbergon opened this issue May 11, 2023 · 4 comments
Closed

Issue with reactive-grpc and the default security interceptors #355

sheinbergon opened this issue May 11, 2023 · 4 comments
Labels
bug Auto-generates notes
Milestone

Comments

@sheinbergon
Copy link

sheinbergon commented May 11, 2023

The most recent version of reactive-grpc 1.2.4 introduced this feature salesforce/reactive-grpc#301
It adds method overloads for Mono<T> with plain T as input params in the base class used for gRPC server implemetnation

When trying to use this API with https://github.com/LogNet/grpc-spring-boot-starter/releases and have its security turned on, this error is thrown:

...Ambiguous method <METHOD NAME> in service...
at org.lognet.springboot.grpc.GRpcServicesRegistry.descriptorToServiceMethod(GRpcServicesRegistry.java:204) ~[grpc-spring-boot-starter-5.1.1.jar:?]
	at org.springframework.util.function.SingletonSupplier.get(SingletonSupplier.java:97) ~[spring-core-6.0.8.jar:6.0.8]
	at org.lognet.springboot.grpc.GRpcServicesRegistry.getGrpServiceMethod(GRpcServicesRegistry.java:124) ~[grpc-spring-boot-starter-5.1.1.jar:?]
	at org.lognet.springboot.grpc.security.SecurityInterceptor.setupGRpcSecurityContext(SecurityInterceptor.java:261) ~[grpc-spring-boot-starter-5.1.1.jar:?]
	at org.lognet.springboot.grpc.security.SecurityInterceptor.interceptCall(SecurityInterceptor.java:143) ~[grpc-spring-boot-starter-5.1.1.jar:?]
	... 14 more

Looking ath the source, it just picks up on the overloaded methods and fails on ambiguoity, which makes sense.
Is there a way to have the server deal with this issue (say, treat these methods as one)?

@jvmlet
Copy link
Collaborator

jvmlet commented May 11, 2023

Thanks for reporting, will check this

@jvmlet jvmlet added the bug Auto-generates notes label May 15, 2023
@jvmlet jvmlet added this to the 5.1.2 milestone May 15, 2023
@jvmlet jvmlet closed this as completed in f0d1b9e May 15, 2023
jvmlet added a commit that referenced this issue May 15, 2023
@jvmlet
Copy link
Collaborator

jvmlet commented May 15, 2023

@sheinbergon , please try with latest 5.1.2-SNAPSHOT, I'll release 5.1.2 once you confirm this is working for you.

@sheinbergon
Copy link
Author

10x. I will test and let you know

@jvmlet
Copy link
Collaborator

jvmlet commented May 24, 2023

5.1.2 is out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Auto-generates notes
Projects
None yet
Development

No branches or pull requests

2 participants