Skip to content

Consider using SmartLifecycle for GRpcServerRunner #181

@Fadelis

Description

@Fadelis

Hi, just wanted to suggest that it would be good to consider using SmartLifecycle interface for GRpcServerRunner instead of CommandLineRunner, DisposableBean as then you could define the order in which beans/services startup and are destroyed. Currently it's hard to do so, if you want to have a graceful shutdown in specific order (ie to start shutting down the grcp server before the downstream services, so that they could respond and finish ongoing requests)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions