@Order attribute on @GrpcGlobalInterceptor ignored when created by @Bean inside a @Configuration

[seime]

The @Order annotation is not detected when used inside a @Configuration and hence the order is undefined (on my JRE the interceptor defined by the last factory method is executed first)

Example:

@Configuration
 public class MyConfig{
     @Bean
     @Order(1) // Ignored
     @GRpcGlobalInterceptor
     public  ServerInterceptor first(){
         return new ServerInterceptor(){ ..} // Executed last
     }

     @Bean
     @Order(2) // Ignored
     @GRpcGlobalInterceptor
     public  ServerInterceptor last(){ 
         return new ServerInterceptor(){ ..} // Executed first
     }
 }

[jvmlet]

Are you able to reproduce by running this test ?

[jvmlet]

Sorry, overlooked that your case is different, was able to reproduce, will be fixed.

[jvmlet]

It's no so easy with spring-boot:1.5.13 and spring:4.3.17. Since I don't want to drop support of 1.5.X, please use this workaround meanwhile.

[asinbow]

It's a bug of the customized re-sorting.

grpc-spring-boot-starter/grpc-spring-boot-starter/src/main/java/org/lognet/springboot/grpc/GRpcServerRunner.java

Line 122 in f959ae4

private Comparator<Object> serverInterceptorOrderComparator() {

    private Comparator<Object> serverInterceptorOrderComparator() {
        Function<Object,Boolean> isOrderAnnotated = obj->{
            // !!!!!!!!!!!!
            // `obj instanceof Method` always returns false, because `obj` are bean instances.
            // !!!!!!!!!!!!
            Order ann = obj instanceof Method ? AnnotationUtils.findAnnotation((Method) obj, Order.class) :
                    AnnotationUtils.findAnnotation(obj.getClass(), Order.class);
            return ann != null;
        };

        // then `isOrderAnnotated` will prioritize on `@Order` on classes, while not `@Order` on bean methods.
       // AnnotationAwareOrderComparator does not work on bean method as well!!!
        return AnnotationAwareOrderComparator.INSTANCE.thenComparing((o1, o2) -> {
            boolean p1 = isOrderAnnotated.apply(o1);
            boolean p2 = isOrderAnnotated.apply(o2);
            return p1 && !p2 ? -1 : p2 && !p1 ? 1 : 0;
        }).reversed();
    }

This is the PR eb6fbf8

I think, for now just to use Spring's default sorted bean list is fine, and the question would be how to get the sorted list right?

// globalInterceptors is not sorted by Spring
Collection<ServerInterceptor> globalInterceptors = getBeanNamesByTypeWithAnnotation(GRpcGlobalInterceptor.class, ServerInterceptor.class)
        .map(name -> applicationContext.getBeanFactory().getBean(name, ServerInterceptor.class))
        .collect(Collectors.toList());

[seime]

Since I don't want to drop support of 1.5.X

Spring Boot end of life was august 2019 - maybe it is time to drop support for it? https://spring.io/blog/2018/07/30/spring-boot-1-x-eol-aug-1st-2019

[jvmlet]

I was dropped science 4.0.0

[skjolber]

And progress on this?

[jvmlet]

Not yet, but your interceptor can implement Ordered interface

[skjolber]

So basically this forces me to either use all the global interceptors (and no interceptors specified on the service), or use no global interceptors (specifing interceptors explicitly on the service). Ordered does not really work that well, however for reuse, creating a custom annotation with @GrpcService should work.

[jvmlet]

What do you mean by Ordered does not really work that well ? Either it works or not. If you have the case that reproduces the out of order execution when interceptor implements Ordered interface, please provide the scenario

[skjolber]

Sorry, I meant does not really work that well for me, as interceptors from third party libraries like TransmitStatusRuntimeExceptionInterceptor does not implement Ordered.

[jvmlet]

The fasters solution I see is to wrap 3rd party interceptor with yours proxy (
aka forwarding interceptor) and let proxy to implement Ordered.
I'll do my best to resolve this.

[jvmlet]

BTW, if you are trying to propagate the validation error, the starter supports spring validation integration.