Skip to content

Commit

Permalink
release version=3.3.0
Browse files Browse the repository at this point in the history
  • Loading branch information
Alexander Furer committed May 29, 2019
1 parent e8aa046 commit df10bab
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 5 deletions.
8 changes: 7 additions & 1 deletion README.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ repositories {
}
dependencies {
compile 'io.github.lognet:grpc-spring-boot-starter:3.2.2'
compile 'io.github.lognet:grpc-spring-boot-starter:3.3.0'
}
Expand Down Expand Up @@ -217,6 +217,12 @@ If you enable both `NettyServer` and `in-process` servers, the `configure` metho
If you need to differentiate between the passed `serverBuilder` s, you can check the type. +
This is the current limitation.

== Consul Integration

Starting from version `3.3.0`, the starter will auto-register the running grpc server in Consul registry if `org.springframework.cloud:spring-cloud-starter-consul-discovery` is in classpath. +
The registered service name will be prefixed with `grpc-` ,i.e. `grpc-${spring.application.name}` to not interfere with standard registered web-service name if you choose to run both embedded `Grpc` and `Web` servers. +


== Eureka Integration

When building production-ready services, the advise is to have separate project for your service(s) gRPC API that holds only proto-generated classes both for server and client side usage. +
Expand Down
4 changes: 4 additions & 0 deletions ReleaseNotes.adoc
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
== Version 3.2.3
* gRPC version upgraded to 1.21.0
* Consul auto-registration support
== Version 3.2.2
* gRPC version upgraded to 1.20.0

Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
version=3.2.3-SNAPSHOT
version=3.3.0
group=io.github.lognet
description=Spring Boot starter for Google RPC.
gitHubUrl=https\://github.com/LogNet/grpc-spring-boot-starter
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ private ConsulRegistration getRegistration(GRpcServerInitializedEvent event) {
if (!properties.isPreferAgentAddress()) {
grpcService.setAddress(properties.getHostname());
}
String appName = "grpc_" + ConsulAutoRegistration.getAppName(properties, applicationContext.getEnvironment());
String appName = "grpc-" + ConsulAutoRegistration.getAppName(properties, applicationContext.getEnvironment());
grpcService.setName(ConsulAutoRegistration.normalizeForDns(appName));
grpcService.setId("grpc_" + ConsulAutoRegistration.getInstanceId(properties, applicationContext));
grpcService.setId("grpc-" + ConsulAutoRegistration.getInstanceId(properties, applicationContext));

/*
service.setTags(createTags(properties));
Expand Down
2 changes: 1 addition & 1 deletion grpc-spring-boot2-starter-demo/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ dependencies {

testCompile project(':grpc-spring-boot-starter-demo')

//testCompile project(':grpc-spring-boot-starter-demo').sourceSets.test.output
testCompile project(':grpc-spring-boot-starter-demo').sourceSets.test.output


testCompile('org.springframework.boot:spring-boot-starter-test')
Expand Down

0 comments on commit df10bab

Please sign in to comment.