Status line update - Remove the thread and use event instead #333
Conversation
RandallFlagg
force-pushed
the
status_line_update
branch
from
ff5328c to
143efac
Compare
|
here are the other changes from #331 included, is this intentional? Reading in the morning is hard. Please change the branch to development :) Otherwise it looks good, this seems to be a old implementation of the Event-Driven Approach that is now outdated, there are probably more places where this is the case. |
The change of PR 331 are included because I did the commit and I didn't feel like starting to separate the commits. If you will take that PR first this will only have the new changes. |
RandallFlagg
force-pushed
the
status_line_update
branch
from
8d3fc5a to
68240b9
Compare
build/_build.csproj
Outdated
| <PackageReference Include="Nuke.GitHub" Version="7.0.0" /> | ||
| <PackageReference Include="NUnit.ConsoleRunner" Version="3.19.2" /> | ||
| <PackageReference Include="NUnit.ConsoleRunner" Version="3.19.0" /> |
There was a problem hiding this comment.
please don't downgrade Nuget packages
There was a problem hiding this comment.
This is a mistake. I never downgrade. I always upgrade. Will check how this happened as I didn't (plan to) commit this file in this PR.
There was a problem hiding this comment.
Yeah thought so, but thats what a review is for
… it with an event
RandallFlagg
force-pushed
the
status_line_update
branch
from
68240b9 to
df62bf5
Compare
@Hirogen see number 3 in #330. I think this is good. Please tell me what you think. I see a major improvement in performance, but I might be missing a lot of use cases. This branch is based on PR #331 so it is better to merge that before this.