Skip to content

Dark theme #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Jul 28, 2022
Merged

Dark theme #252

merged 34 commits into from
Jul 28, 2022

Conversation

jrouzies-fr
Copy link

Add option to enable a Dark Mode / Theme

@jrouzies-fr jrouzies-fr reopened this Jul 27, 2022
@Hirogen Hirogen self-requested a review July 27, 2022 12:37
@Hirogen
Copy link
Collaborator

Hirogen commented Jul 27, 2022

Ill review it in the evening :)

@Hirogen Hirogen linked an issue Jul 27, 2022 that may be closed by this pull request
@jrouzies-fr
Copy link
Author

jrouzies-fr commented Jul 27, 2022

Ill review it in the evening :)

Great!

I was able to fix the menus white border, the timeshift textbox background, and some improvements to filters / bookmarks window as well.

image

@Hirogen
Copy link
Collaborator

Hirogen commented Jul 27, 2022

are the red cells only for the screenshot?

@jrouzies-fr
Copy link
Author

jrouzies-fr commented Jul 27, 2022 via email

Copy link
Collaborator

@Hirogen Hirogen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished review added a few small comments, more of coding style, everything else looks good 😃

@Hirogen
Copy link
Collaborator

Hirogen commented Jul 27, 2022

Yes it’s just a test Highlight ! Feel free to clone the branch to check it

no need, i believe you. I'm eager to create a test release after the merge 😄

@Hirogen Hirogen merged commit 059bae6 into LogExperts:Dark-Theme Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Dark Theme
3 participants