Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update overview page top section #175

Merged
merged 9 commits into from
Feb 25, 2023
Merged

Update overview page top section #175

merged 9 commits into from
Feb 25, 2023

Conversation

ViridianCitrus
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Feb 24, 2023 •
edited
Loading

✅ Deploy Preview for lodestone-dashboard ready!

Name Link
🔨 Latest commit caf5b19
🔍 Latest deploy log https://app.netlify.com/sites/lodestone-dashboard/deploys/63fa6f46a95306000725549c
😎 Deploy Preview https://deploy-preview-175--lodestone-dashboard.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Feb 24, 2023 •
edited
Loading

✅ Deploy Preview for lodestone-storybook ready!

Name Link
🔨 Latest commit caf5b19
🔍 Latest deploy log https://app.netlify.com/sites/lodestone-storybook/deploys/63fa6f46e0c31d0008468f75
😎 Deploy Preview https://deploy-preview-175--lodestone-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ViridianCitrus ViridianCitrus self-assigned this Feb 24, 2023
@ViridianCitrus ViridianCitrus added this to the 0.4.3 milestone Feb 24, 2023
@ViridianCitrus ViridianCitrus marked this pull request as ready for review February 25, 2023 04:15
Ynng
Ynng requested changes Feb 25, 2023
View reviewed changes
src/components/ClipboardTextfield.tsx Outdated Show resolved Hide resolved
src/components/Minecraft/MinecraftOverview.tsx Show resolved Hide resolved
Ynng
Ynng requested changes Feb 25, 2023
View reviewed changes
Copy link
Member

@Ynng Ynng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
tl;dr: copy ip button looks weird

src/components/ClipboardTextfield.tsx Outdated Show resolved Hide resolved
Ynng
Ynng requested changes Feb 25, 2023
View reviewed changes
src/components/ClipboardTextfield.tsx Outdated Show resolved Hide resolved
Ynng
Ynng requested changes Feb 25, 2023
View reviewed changes
Copy link
Member

@Ynng Ynng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to get rid of the two non breaking space    too, they are messing with the spacing

Ynng
Ynng approved these changes Feb 25, 2023
View reviewed changes
Copy link
Member

@Ynng Ynng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ViridianCitrus ViridianCitrus merged commit 851cfac into 0.4.3 Feb 25, 2023
@ViridianCitrus ViridianCitrus deleted the 146-new-overview-page-top-section branch February 25, 2023 21:37
Ynng pushed a commit that referenced this pull request Jul 17, 2023
@CheatCod
Merge pull request #175 from Lodestone-Team/update-bindings
cf73fbf 
Update ts-rs bindings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ynng Ynng Ynng approved these changes

Assignees

@ViridianCitrus ViridianCitrus

Labels
None yet
Projects
None yet
Milestone
0.4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@ViridianCitrus @Ynng