Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix instance highlighting bug #168

Merged
merged 3 commits into from
Feb 22, 2023
Merged

Fix instance highlighting bug #168

merged 3 commits into from
Feb 22, 2023

Conversation

ViridianCitrus
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Feb 21, 2023 •
edited
Loading

✅ Deploy Preview for lodestone-dashboard ready!

Name Link
🔨 Latest commit db17ee0
🔍 Latest deploy log https://app.netlify.com/sites/lodestone-dashboard/deploys/63f56069f707bc0007b0370d
😎 Deploy Preview https://deploy-preview-168--lodestone-dashboard.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ViridianCitrus ViridianCitrus changed the title Add radiogroup resetting Fix instance highlighting bug Feb 21, 2023
@netlify
Copy link

netlify bot commented Feb 21, 2023 •
edited
Loading

✅ Deploy Preview for lodestone-storybook ready!

Name Link
🔨 Latest commit db17ee0
🔍 Latest deploy log https://app.netlify.com/sites/lodestone-storybook/deploys/63f5606935cbd90008c87684
😎 Deploy Preview https://deploy-preview-168--lodestone-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ViridianCitrus
Fix radiogroup to deselect on home
aa2bdf9 
fixed interface to accept null values
@ViridianCitrus ViridianCitrus added the bug Something isn't working label Feb 21, 2023
@ViridianCitrus ViridianCitrus self-assigned this Feb 21, 2023
@ViridianCitrus ViridianCitrus marked this pull request as ready for review February 21, 2023 03:48
Base automatically changed from 0.4.2 to main February 21, 2023 22:02
@Ynng Ynng changed the base branch from main to 0.4.3 February 21, 2023 22:03
Ynng
Ynng requested changes Feb 21, 2023
View reviewed changes
Copy link
Member

@Ynng Ynng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but it's not building correctly. Can you try to npm run build locally and make sure it builds?

Ynng
Ynng approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@Ynng Ynng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good!

@ViridianCitrus ViridianCitrus merged commit 79349e5 into 0.4.3 Feb 22, 2023
@ViridianCitrus ViridianCitrus deleted the 127-instance-highlight-no-unhighlighting branch February 22, 2023 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ynng Ynng Ynng approved these changes

@joeywangzr joeywangzr Awaiting requested review from joeywangzr

Assignees

@ViridianCitrus ViridianCitrus

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ViridianCitrus @Ynng