-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Left Navbar implementation #152
Conversation
…, and new styling
✅ Deploy Preview for lodestone-dashboard ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for lodestone-storybook ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The "power" button doesn't have keybaord focus border
- the "power" button isn't really a square?
- Scrolling behavior of the left nav is still not perfect
- When I change instant, the tab jumps back to /overview, can we keep the current tab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
IconButton
used for core setting and power on/off of a selected instance/dashboard/{tab_name}
. The new default isdashboard/overview
*Currently, the navbar and user login dropdown have hardcoded widths and will require investigation to determine how we can truncate the username whilst using dynamic width.