Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rcon Setting (for 0.4.1) #115

Merged
merged 10 commits into from
Jan 19, 2023
Merged

Rcon Setting (for 0.4.1) #115

merged 10 commits into from
Jan 19, 2023

Conversation

NicholasLin718
Copy link
Contributor

Added RCON settings for rcon-enable and rcon.password as requested in this ticket

  • Added new password type to Advanced Setting/Setting fields
  • Implemented a view password icon that will update a newly introduced type state in the InputBox called typeModified (variable name can be changed if there is a clearer one)

@netlify
Copy link

netlify bot commented Jan 18, 2023

Deploy Preview for lodestone-dashboard ready!

Name Link
🔨 Latest commit 0cddd25
🔍 Latest deploy log https://app.netlify.com/sites/lodestone-dashboard/deploys/63c8c984452fac0009b7098c
😎 Deploy Preview https://deploy-preview-115--lodestone-dashboard.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Ynng
Copy link
Member

Ynng commented Jan 18, 2023

Something is causing build to fail.
Please run npm run build locally and make sure it succeeds.

Regarding the modifiedType. Would it be possible to just have type and simply update it on the fly?

@Ynng
Copy link
Member

Ynng commented Jan 18, 2023

Sorry I read it wrong.
typeModified is good.

@Ynng
Copy link
Member

Ynng commented Jan 18, 2023

Also in the future, you can write "closes #103" in the description to link the issue to this pr

@Ynng Ynng self-requested a review January 19, 2023 00:11
@Ynng
Copy link
Member

Ynng commented Jan 19, 2023

image
The little eye icon doesn't show up until I edit the text

@Ynng
Copy link
Member

Ynng commented Jan 19, 2023

Looks good for merge

@NicholasLin718 NicholasLin718 merged commit 322dd24 into 0.4.1 Jan 19, 2023
@Ynng Ynng deleted the RCONsetting branch January 19, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants