Switch to ember-d3 now that ember-cli-d3-shape is deprecated #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanvanderbyl
changed the title
|
@ivanvanderbyl thanks so much! yes, I'll confirm in a parent app. |
|
alright, works great! Merging. |
ghost
merged commit 
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's coming time to retire
ember-cli-d3-shapeand useember-d3once we cut a new release. I've opened this PR to test compatibility with the new module resolving behaviour before calling it Production Ready™.Update 10/17/16
Tests run, everything seems to be good to go. Can someone confirm this in another app?