use allowance holder api for 0x v2 eip5792 txs #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Deploying llamaswap with
|
| Latest commit: |
f591685
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b6249bc1.llamaswap.pages.dev |
| Branch Preview URL: | https://0x-v2-allowance-holder.llamaswap.pages.dev |
0xngmi
requested changes
Jun 21, 2025
| return null; | ||
| }); | ||
|
|
||
| // fetch permit2 quote if allowance holder quote is not available |
There was a problem hiding this comment.
the code doesnt implement what this comment is saying?
| if (!signature) { | ||
| throw { reason: 'Signature is required' } | ||
| if (rawQuote.isSignatureNeededForSwap && tokens.fromToken.address !== zeroAddress && !signature) { | ||
| throw { reason: 'Signature is required' }; | ||
| } | ||
|
|
||
| const signatureLengthInHex = numberToHex(size(signature), { |
There was a problem hiding this comment.
when signature is empty, does this work?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.