Skip to content

Conversation

@ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Dec 25, 2025

Description

This PR adds screenshots to tests. The goal is to be able to easily review what the tray icon looks like in different states.

TODO:

  • fix sonar warnings
  • post images in PR comment and/or github step summary
    • secondary workflow to:
      • download artifacts from first job
      • publish images to a screenshot branch
      • comment on PR
        • compare master branch images to PR images, make obvious if images are mismatched (need to remove date/time for reliable comparison)
  • specific tray region for screenshots
  • capture more states/events of tray
  • minimize all windows before tests (on windows)
  • use gnome/default DE on linux?
  • ensure icons are actually used in our tests
  • improve test coverage

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov
Copy link

codecov bot commented Dec 25, 2025

Codecov Report

❌ Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.20%. Comparing base (09c5784) to head (31f20b9).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/tray_darwin.m 87.50% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
+ Coverage   62.01%   64.20%   +2.18%     
==========================================
  Files           4        4              
  Lines         337      352      +15     
  Branches       63       65       +2     
==========================================
+ Hits          209      226      +17     
+ Misses         92       91       -1     
+ Partials       36       35       -1     
Flag Coverage Δ
Linux 49.53% <100.00%> (+0.47%) ⬆️
Windows 57.73% <ø> (+1.03%) ⬆️
libappindicator3-dev 49.53% <100.00%> (+0.47%) ⬆️
libayatana-appindicator3-dev 49.53% <100.00%> (?)
macOS 62.88% <87.50%> (+6.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/tray_linux.c 63.09% <100.00%> (+0.44%) ⬆️
src/tray_darwin.m 87.14% <87.50%> (+3.21%) ⬆️

... and 1 file with indirect coverage changes

@ReenigneArcher ReenigneArcher force-pushed the test/add-screenshots branch 8 times, most recently from e10b0fe to 2e7f594 Compare December 25, 2025 04:18
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
31 New issues
31 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants