Repository navigation
fix(linux): prevent stuck keys from uinput repeat races - #198
Merged
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #198 +/- ##
==========================================
+ Coverage 73.73% 73.74% +0.01%
==========================================
Files 43 43
Lines 10704 10670 -34
Branches 3696 3677 -19
==========================================
- Hits 7893 7869 -24
+ Misses 2447 2442 -5
+ Partials 364 359 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Harness.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The uinput keyboard repeat thread can replay a stale key press after a release, leaving the key held in the kernel while the library tracks it as released. Remove the repeat thread and its pressed-key cache so only caller-submitted transitions reach the device. Key repeat remains with the compositor or X server.
Document that the uinput backend ignores
auto_repeat_interval_ms, and add event-capture and real-uinput regression coverage.Screenshot
Issues Fixed or Closed
Roadmap Issues
Testing
EVIOCGKEYreportedKEY_Fstill down after release. With the fix, both native tests pass: libinput keyboard transitions and two seconds of rapid press/release cycles with kernel-state checks and a delayed check for a late press.test_libvirtualhidandgamepad_adapter; all 146 device-independent tests passed.test_libvirtualhid, andgamepad_adapter; all 52 selected core API, report, adapter, and lifecycle tests passed.git diff --check, and Doxygen passed with no documentation warnings.Type of Change
Checklist
AI Usage
See our AI usage policy.
Generated by Codex using
gpt-6.1-solwithxhighthinking.