Skip to content
This repository has been archived by the owner on Oct 13, 2024. It is now read-only.

fix(themes): fix incorrect audio container and add unit testing #98

Conversation

ReenigneArcher
Copy link
Member

Description

This "should" fix themes being downloaded in the wrong audio container. Currently they are being downloaded in WebM, this changes that to be an Mp4 container with no video stream.

Additionally, unit testing is added using Xunit.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher
Copy link
Member Author

ReenigneArcher commented Sep 15, 2023

Todo:

  • add dotnet test to CI
  • add code coverage

@ReenigneArcher ReenigneArcher force-pushed the fix(themes)-fix-incorrect-audio-container-and-add-unit-testing branch 3 times, most recently from a1ed922 to fb8267a Compare September 15, 2023 23:21
@codecov
Copy link

codecov bot commented Sep 15, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@ReenigneArcher ReenigneArcher force-pushed the fix(themes)-fix-incorrect-audio-container-and-add-unit-testing branch from fb8267a to 03adc28 Compare September 15, 2023 23:28
@ReenigneArcher ReenigneArcher marked this pull request as ready for review September 15, 2023 23:42
@ReenigneArcher ReenigneArcher merged commit 80ed39a into nightly Sep 15, 2023
23 checks passed
@ReenigneArcher ReenigneArcher deleted the fix(themes)-fix-incorrect-audio-container-and-add-unit-testing branch September 15, 2023 23:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant