Skip to content
This repository has been archived by the owner on Oct 13, 2024. It is now read-only.

fix(docker): fix s6 init run script execution #74

Merged

Conversation

ReenigneArcher
Copy link
Member

Description

Fixes execution of docker mod s6 initialization run script. Additionally, renames some directories and the run file to follow better practices.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@github-actions
Copy link

github-actions bot commented Aug 25, 2023

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.2.1
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@ReenigneArcher ReenigneArcher force-pushed the fix(docker)-fix-s6-init-run-script-execution branch 2 times, most recently from 8951fb8 to 9bf3f1a Compare August 25, 2023 15:59
@ReenigneArcher ReenigneArcher force-pushed the fix(docker)-fix-s6-init-run-script-execution branch from 9bf3f1a to 2fbd189 Compare August 25, 2023 16:08
@ReenigneArcher ReenigneArcher merged commit 6e38c29 into nightly Aug 27, 2023
20 checks passed
@ReenigneArcher ReenigneArcher deleted the fix(docker)-fix-s6-init-run-script-execution branch August 27, 2023 04:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant