Display initialization and frame ownership fixes#850
Display initialization and frame ownership fixes#850cgutman merged 3 commits intoLizardByte:nightlyfrom
Conversation
There was a problem hiding this comment.
I tested over 100 fullscreen transitions using the same testcase in #823 with this PR and couldn't reproduce the problem. Additionally, I couldn't trigger the Capture size changed message, but I'm guessing that the changes here might impact that. Seems fine to me.
|
I also tested the issue related to the dummy frame on first connect:
Prior to this PR, sometimes the stream would stay black indefinitely until some input triggers a screen refresh. With the PR, the new behaviour is that a black screen may occur on connect that lasts for 1 second followed by the proper desktop image. I assume this delay is likely due to |
Description
This fixes some issues with capture initialization/reinitialization that could cause us to discard good frames. When we reinitialize encoding, the encoder thread will free any pending frames and encode an initial dummy frame. This could result in the first captured frame from the newly reinitialized display being dropped or immediately superseded by a dummy frame.
@psyke83 Please give this a try to ensure it doesn't regress #823. It should also fix the black screen issue when starting a stream or triggering a UAC prompt when no new frames are being generated.
Screenshot
Issues Fixed or Closed
Type of Change
.github/...)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.