Fix streaming to multiple clients from hardware encoder on Windows#798
Merged
cgutman merged 1 commit intoLizardByte:nightlyfrom Jan 18, 2023
Merged
Fix streaming to multiple clients from hardware encoder on Windows#798cgutman merged 1 commit intoLizardByte:nightlyfrom
cgutman merged 1 commit intoLizardByte:nightlyfrom
Conversation
Contributor
|
I've tested this pull request and it solves the problem for me. Thanks for fixing this bug! |
1d8e577 to
c42eefd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#668 broke the multi-client streaming scenario because it assumes a single
img_tis shared between a single capture device and a single encoding device. When using multiple clients, there is a newhwdevice_tfor each independent stream, so there can be an arbitrary number of encoding devices sharing a single capture texture. This PR fixes this issue by keeping a map of encoder image context structures in thehwdevice_t, so each separate encoding device can open the same capture texture and mutex properly.Screenshot
Issues Fixed or Closed
Fixes #795
Type of Change
.github/...)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.