Enable Mouse Keys while streaming for systems with no mouse plugged in#721
Merged
ReenigneArcher merged 1 commit intoLizardByte:nightlyfrom Jan 7, 2023
Merged
Conversation
Contributor
|
Tested with mouse driver disabled on Windows 10 - seems to be working perfectly. Mouse Keys is enabled (if not already so) on stream start, making the cursor visible in this situation. Mouse Keys setting is also restored to the original setting before stream began. |
dfed2bb to
48abee5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a workaround for the issue where Windows systems with no physical mouse connected would not display the mouse cursor (OS behavior since Windows 8). As a workaround, we can enable Mouse Keys for the duration of the streaming session which will force the mouse cursor to be displayed. Fortunately for us, Mouse Keys doesn't see input from
SendInput()so we don't have to do anything special to make the number pad work either.Screenshot
Issues Fixed or Closed
Type of Change
.github/...)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.