Fix Windows masked cursor blending with GPU encoders#720
Merged
ReenigneArcher merged 1 commit intoLizardByte:nightlyfrom Jan 7, 2023
Merged
Fix Windows masked cursor blending with GPU encoders#720ReenigneArcher merged 1 commit intoLizardByte:nightlyfrom
ReenigneArcher merged 1 commit intoLizardByte:nightlyfrom
Conversation
2 tasks
Contributor
|
I tested on Windows 10 and, comparing to the host screen, can't identify any problems with the colour/transparency reproduction for masked or inverted cursors. Seems good to me. |
b50b1e2 to
c03eaa1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Blending of masked color and monochrome cursors was broken when using GPU accelerated encoding on Windows. Color masked cursors would be rendered completely transparently (no cursor at all) and monochrome masked cursors would not be blended with the display contents at all (using fixed colors instead).
This fixes the I-beam cursor when using High DPI (which is a masked color cursor) and the inverted cursor style (which uses monochrome cursors with inversion masks).
Screenshot
Issues Fixed or Closed
Fixes #513
Type of Change
.github/...)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.