Skip to content

Conversation

@psyke83
Copy link
Contributor

@psyke83 psyke83 commented Jan 27, 2026

Description

Users no longer need to see a fatal error related to setcap in the WebUI now that XDG portal is available.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@psyke83 psyke83 marked this pull request as ready for review January 27, 2026 03:14
@ReenigneArcher ReenigneArcher added this to the xdg portal grab milestone Jan 27, 2026
@sonarqubecloud
Copy link

@ReenigneArcher ReenigneArcher changed the title linux: kmsgrab: deprioritize setcap error message for non-KMS Wayland… fix(linux/kmsgrab): deprioritize setcap error message for non-KMS Wayland Jan 27, 2026
@ReenigneArcher ReenigneArcher changed the title fix(linux/kmsgrab): deprioritize setcap error message for non-KMS Wayland fix(linux/kmsgrab): deprioritize setcap error message for non-KMS Wayland users Jan 27, 2026
@codecov
Copy link

codecov bot commented Jan 27, 2026

Bundle Report

Bundle size has no change ✅

@ReenigneArcher
Copy link
Member

copr failure is unrelated, can't find npm in Fedora rawhide

@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 11.07%. Comparing base (faf2b12) to head (4f75b2a).
⚠️ Report is 1 commits behind head on feat/linux/add-xdg-portal-grab.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/platform/linux/kmsgrab.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@                        Coverage Diff                         @@
##           feat/linux/add-xdg-portal-grab    #4635      +/-   ##
==================================================================
- Coverage                           15.02%   11.07%   -3.96%     
==================================================================
  Files                                  95       69      -26     
  Lines                               19804    12181    -7623     
  Branches                             9132     5882    -3250     
==================================================================
- Hits                                 2976     1349    -1627     
+ Misses                              15013    10355    -4658     
+ Partials                             1815      477    -1338     
Flag Coverage Δ
Archlinux 11.07% <0.00%> (ø)
FreeBSD-14.3-amd64 ?
Homebrew-ubuntu-22.04 ?
Linux-AppImage ?
Windows-AMD64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/linux/kmsgrab.cpp 0.34% <0.00%> (-3.49%) ⬇️

... and 85 files with indirect coverage changes

@ReenigneArcher ReenigneArcher merged commit 67f3204 into LizardByte:feat/linux/add-xdg-portal-grab Jan 27, 2026
52 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants