Skip to content

Conversation

@psyke83
Copy link
Contributor

@psyke83 psyke83 commented Jan 24, 2026

Description

Ref: #2333

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@sonarqubecloud
Copy link

@ReenigneArcher ReenigneArcher changed the title linux: xdgportal: sync capture delay logic/logging with x11/kms fix(linux/xdgportal): sync capture delay logic/logging with x11/kms Jan 24, 2026
@ReenigneArcher ReenigneArcher added this to the xdg portal grab milestone Jan 24, 2026
@codecov
Copy link

codecov bot commented Jan 24, 2026

Bundle Report

Bundle size has no change ✅

@codecov
Copy link

codecov bot commented Jan 24, 2026

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 15.12%. Comparing base (ac222ae) to head (7c8c6ce).
⚠️ Report is 1 commits behind head on feat/linux/add-xdg-portal-grab.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/platform/linux/portalgrab.cpp 0.00% 7 Missing ⚠️
Additional details and impacted files
@@                        Coverage Diff                         @@
##           feat/linux/add-xdg-portal-grab    #4622      +/-   ##
==================================================================
- Coverage                           15.13%   15.12%   -0.01%     
==================================================================
  Files                                  95       95              
  Lines                               19708    19710       +2     
  Branches                             9067     9069       +2     
==================================================================
  Hits                                 2982     2982              
- Misses                              13221    13222       +1     
- Partials                             3505     3506       +1     
Flag Coverage Δ
Archlinux 11.10% <0.00%> (-0.01%) ⬇️
FreeBSD-14.3-amd64 13.25% <0.00%> (+<0.01%) ⬆️
Homebrew-ubuntu-22.04 13.34% <0.00%> (-0.01%) ⬇️
Linux-AppImage 11.50% <0.00%> (-0.01%) ⬇️
Windows-AMD64 13.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/linux/portalgrab.cpp 4.53% <0.00%> (-0.02%) ⬇️

... and 12 files with indirect coverage changes

@ReenigneArcher ReenigneArcher merged commit 3eb0a23 into LizardByte:feat/linux/add-xdg-portal-grab Jan 24, 2026
53 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants