Skip to content

Conversation

@ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Dec 18, 2025

Description

Corrects the namespace declaration from 'process::inline v1' to 'process::v1' fixing a compile error on Windows.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov
Copy link

codecov bot commented Dec 18, 2025

Bundle Report

Bundle size has no change ✅

@ReenigneArcher ReenigneArcher force-pushed the build/fix-namespace-declaration-for-boost-process-v1 branch from 32b83ec to 0064c09 Compare December 18, 2025 05:00
@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 15.27%. Comparing base (eb3afd4) to head (0064c09).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4518      +/-   ##
==========================================
- Coverage   15.33%   15.27%   -0.07%     
==========================================
  Files          92       91       -1     
  Lines       18974    18971       -3     
  Branches     8704     8702       -2     
==========================================
- Hits         2910     2898      -12     
+ Misses      14819    12767    -2052     
- Partials     1245     3306    +2061     
Flag Coverage Δ
Archlinux ?
FreeBSD-14.3-aarch64 ?
FreeBSD-14.3-amd64 13.59% <ø> (+<0.01%) ⬆️
Homebrew-ubuntu-latest 13.77% <ø> (ø)
Linux-AppImage 11.58% <ø> (ø)
Windows-AMD64 13.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/common.h 28.84% <ø> (ø)
src/platform/windows/display_base.cpp 35.59% <ø> (ø)
src/platform/windows/misc.cpp 15.65% <ø> (ø)

... and 48 files with indirect coverage changes

@ReenigneArcher ReenigneArcher marked this pull request as ready for review December 18, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants