Skip to content

Conversation

@MiroKaku
Copy link
Contributor

Description

Fixed the issue that generating cmake configuration on Windows platform failed after BUILD_TESTS was set to OFF.

Error message:

CMake Error at cmake/targets/common.cmake:116 (set_source_files_properties):
  set_source_files_properties given non-existent DIRECTORY

Screenshot

None

Issues Fixed or Closed

None

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@sonarqubecloud
Copy link

@cgutman
Copy link
Collaborator

cgutman commented Nov 26, 2024

Not sure if there's a cleaner way to do that but LGTM

@codecov
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.13%. Comparing base (d5854ae) to head (7b92729).
Report is 96 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3416   +/-   ##
=======================================
  Coverage   11.13%   11.13%           
=======================================
  Files          99       99           
  Lines       17253    17253           
  Branches     8045     8045           
=======================================
  Hits         1921     1921           
  Misses      12639    12639           
  Partials     2693     2693           
Flag Coverage Δ
Linux 8.37% <ø> (ø)
Windows 5.31% <ø> (ø)
macOS-13 13.64% <ø> (+0.01%) ⬆️
macOS-14 12.63% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants