Skip to content

Conversation

@cfalas
Copy link
Contributor

@cfalas cfalas commented Jul 13, 2024

Description

Currently, pen input is unusable on linux, because of the following issues, as per #2756

  • No pressure sensitivity while using the pen
  • Pen doesn't release when hovering after the first touch

This is caused by the fact that EVENT_MOVE events are considered to not touch the screen, which is not the case.

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@CLAassistant
Copy link

CLAassistant commented Jul 13, 2024

CLA assistant check
All committers have signed the CLA.

@ReenigneArcher ReenigneArcher requested a review from Hazer July 13, 2024 15:11
@codecov
Copy link

codecov bot commented Jul 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 9.04%. Comparing base (ba68caf) to head (402233a).
Report is 131 commits behind head on master.

Files with missing lines Patch % Lines
src/platform/linux/input/inputtino_pen.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #2841    +/-   ##
=======================================
  Coverage    9.04%   9.04%            
=======================================
  Files          96      96            
  Lines       17437   17437            
  Branches     8276    8275     -1     
=======================================
  Hits         1578    1578            
- Misses      12975   13126   +151     
+ Partials     2884    2733   -151     
Flag Coverage Δ
Linux 6.80% <0.00%> (ø)
Windows 4.25% <ø> (ø)
macOS-12 10.06% <ø> (-0.02%) ⬇️
macOS-13 9.97% <ø> (ø)
macOS-14 10.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/linux/input/inputtino_pen.cpp 0.00% <0.00%> (ø)

... and 27 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pen input active while hovering

4 participants