Skip to content

Conversation

@ReenigneArcher
Copy link
Member

Description

ffmpeg build names have changed in LizardByte/build-deps#326

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher
Copy link
Member Author

ReenigneArcher commented May 26, 2024

@chewi FYI, and requesting a review if you have time.

@codecov
Copy link

codecov bot commented May 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 7.03%. Comparing base (8a0762d) to head (4d66c3e).
Report is 155 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2577   +/-   ##
======================================
  Coverage    7.03%   7.03%           
======================================
  Files          87      87           
  Lines       17698   17698           
  Branches     8407    8407           
======================================
  Hits         1245    1245           
- Misses      13713   13749   +36     
+ Partials     2740    2704   -36     
Flag Coverage Δ
Linux 5.35% <ø> (ø)
Windows 2.56% <ø> (ø)
macOS-12 8.05% <ø> (ø)
macOS-13 7.98% <ø> (+0.01%) ⬆️
macOS-14 8.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 23 files with indirect coverage changes

@ReenigneArcher ReenigneArcher force-pushed the build(deps)-use-new-ffmpeg-build-names branch from 6c3f4c6 to 4d66c3e Compare May 26, 2024 23:11
@ReenigneArcher ReenigneArcher merged commit 992bf9c into master May 27, 2024
@ReenigneArcher ReenigneArcher deleted the build(deps)-use-new-ffmpeg-build-names branch May 27, 2024 00:36
@chewi
Copy link
Contributor

chewi commented May 27, 2024

Sorry I couldn't review, I'm away at the moment. Thanks for doing this.

KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Jun 6, 2024
c2vi pushed a commit to c2vi/Sunshine that referenced this pull request Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants