Add workaround for RTX HDR driver bug#2171
Merged
cgutman merged 1 commit intoLizardByte:nightlyfrom Mar 1, 2024
Merged
Conversation
c8d31b8 to
8c3b062
Compare
|
As a note, a temporary workaround for the repeat crashing is disable HDR in windows. |
|
Does this also fix the issue that HDR is not streamed properly when RTX-HDR is enabled for a game? |
RStanbouly
approved these changes
Feb 28, 2024
RStanbouly
left a comment
There was a problem hiding this comment.
Nit is relatively minor, otherwise lgtm and it doesn't seem to be failing any checks.
As a side effect, it avoids useless allocations and uploads of a zeroed memory buffer to clear the dummy image textures.
8c3b062 to
0e7c175
Compare
Collaborator
Author
|
The minimal workaround turned out to not really be suitable as there were still some major stability issues with this texture upload codepath in the driver, even when it didn't crash by overreading our buffer (the event log was full of GPU error logs from nvlddmkm). I had to resort to a more complex fix, but it at least provides (small) performance benefits for all cases. |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This reworks our dummy image handling to avoid triggering a driver bug with 551.61 drivers and RTX HDR enabled. It also provides a small performance improvement for that (uncommon) case of interacting with dummy image textures.
Screenshot
Issues Fixed or Closed
Fixes #2163
Type of Change
.github/...)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.