Skip to content

Fix failed to locate output device on invalid configurations#1030

Closed
Nonary wants to merge 2 commits intoLizardByte:nightlyfrom
Nonary:failed_output_bugfixes
Closed

Fix failed to locate output device on invalid configurations#1030
Nonary wants to merge 2 commits intoLizardByte:nightlyfrom
Nonary:failed_output_bugfixes

Conversation

@Nonary
Copy link

@Nonary Nonary commented Mar 11, 2023

Description

It fixes an issue that caused sunshine to fail to start if users provided an invalid display name in the configuration file.
It also fixes a false positive in the ddprobe tool, which could cause duplicateoutput() test failed [0x887a0004] errors

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@CLAassistant
Copy link

CLAassistant commented Mar 11, 2023

CLA assistant check
All committers have signed the CLA.

@ReenigneArcher
Copy link
Member

Updating w/ rebase to make this easier to fix conflicts after adjusting clang-format rules

Nonary added 2 commits March 27, 2023 21:18
The previous method would not work for the other references of reset_display().

Also slightly refactored the method, to make it easier to add more reset conditions if they are discovered in the future
@Nonary

This comment was marked as spam.

@Nonary Nonary closed this Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants