Skip to content

Conversation

@ARYPROGRAMMER
Copy link

This Adds the Feature Mentioned in Issue#328

Specifically, for all stories with a GitHub Repo preview I have added an Enhancement to the existing UI to fetch the details of the repo specified and give its preview without even opening it. Thereby providing the user a more seamless experience.

  • All features are Working
  • Free and Flexible to Change further, Main Logic Implemented Separately
  • No Breaking Changes
  • Added Enhancement requires Admin's GitHub PAT (Personal Access Token)
  • No Render Issues or Time Lags Observed

Sample Image :

Realtime App View

@Livinglist
Copy link
Owner

Hi @ARYPROGRAMMER, thx for your PR, I'm hesitant about adding GitHub preview to the app since I want to keep the app as lean as possible, using FutureBuilder in the root view is also not a good idea since it doesn't cache the response and will request every time the view is reattached.

@ARYPROGRAMMER
Copy link
Author

hey @Livinglist , thanks for reviewing my PR. I have a solution which I guarantee you will like. I'll create a GithubCubit Class in the widget tree and make call to it only when needed. Thereby making the app lean. If you want I can start working on it right now and request a new PR or if you have any suggestions, I'll be happy to discuss more on this as this is one of the most required client need.

@ARYPROGRAMMER
Copy link
Author

Hey @Livinglist I am done with new changes and thus I'll open a new PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants