store app data by shm transport when shm segment is created #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariat-atg
requested changes
Sep 7, 2021
| @@ -371,12 +371,12 @@ class Router extends EnhancedEventEmitter_1.EnhancedEventEmitter { | |||
| * @async | |||
| * @returns {ShmTransport} | |||
| */ | |||
| async createShmTransport({ listenIp, shm, log, appData = {} }) { | |||
There was a problem hiding this comment.
Please leave appData an object for consistency with other similar transport creating APIs. We assume that it is an object and it may contain information about callId, peerId, streamName and mirrorId. I am testing the branch where I actually pick that data in shm and add into logs.
If you are passing a special string for shm apps it would be better to add it under shm object (the 2nd param in this function).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass the appData parameter which is provided by xcode api controller through pvc-packets all the way to the shm transport and into the shm when the shm is created. The appData is a json formatter as a string