Add setting to control the timer timing method#67
Open
coletrammer wants to merge 1 commit intoLiveSplit:masterfrom
Open
Add setting to control the timer timing method#67coletrammer wants to merge 1 commit intoLiveSplit:masterfrom
coletrammer wants to merge 1 commit intoLiveSplit:masterfrom
Conversation
The toggle timing method hotkey is still applicable but is not persistent. This setting is mostly useful to control the default timing method used when loading splits initially.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new combo box under the layout path to select the timing method (defaulting to real-time). The timing method gets applied every time a new
Runis created, so it applies when first launching obs and when choosing a new split file. Additionally, if the setting changes this is applied to the timer.The existing hotkey for toggling the timing method still exists but is not persistent. So the hotkey can be used to view the real-time (or game time) splits temporarily but the value of the setting remains unchanged.
I'm very happy about this PR because I have been switching to game time using the hotkey every time I load obs or a new split file, and this much more convenient.
Closes #59.