Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto_splitting feature: Add requests for auto splitter settings management #713

Merged
merged 3 commits into from
Aug 25, 2023

Commits on Aug 20, 2023

  1. auto_splitting: Add requests for settings

    This patch adds 4 requests to the auto-splitting feature so that the library users are able to manage the auto splitter settings:
    - GetSettings: Gets all of the user settings that are meant to be shown to the runner
    - GetSettingsValue(key: String): Gets the SettingValue of a specific setting
    - SetSettingsValue(key: String, value: SettingValue): Sets the SettingValue of a specific setting
    - ReloadScript: Helper request that will reload the current script while keeping the same SettingsStore
    
    This adds 3 new possible errors to tell the user what could have went wrong while executing the requests.
    
    It also re export some of the useful types for settings related things.
    
    Lastly, there's a new accessor in the runtime to get the SettingsStore as mutable and UserSetting / UserSettingKind are now clonable so that we can pass them along with the requests.
    Refragg committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    5ec7210 View commit details
    Browse the repository at this point in the history
  2. Fix clippy lints warnings

    Refragg committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    1edfdd4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4bba3b9 View commit details
    Browse the repository at this point in the history