Merged
Conversation
CryZe
added
enhancement
We have had a really outdated version of Font Awesome directly vendored into our repository. Not only was it outdated, but it also is shipped as a font file, including all the icons, even though we only use a small subset of them. By switching to Lucide, we not only are depending on something more up to date, but now the icons can also be tree shaked.
Collaborator
Author
|
As expected, this shaved off around 10% of our compressed bundle size. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have had a really outdated version of Font Awesome directly vendored into our repository. Not only was it outdated, but it also is shipped as a font file, including all the icons, even though we only use a small subset of them. By switching to Lucide, we not only are depending on something more up to date, but now the icons can also be tree shaked.
This also updates some of our CSS to use flex box and grid instead of manually positioning with margins.