Allow Invalid Color Component Inputs#1012
Merged
CryZe merged 1 commit intoLiveSplit:masterfrom Feb 15, 2025
Merged
Conversation
CryZe
added
enhancement
Apparently React behaves differently from Dioxus in that it doesn't allow changing inputs if they don't affect the value that they are bound to. So I spent some time on implementing some proper validation logic for the color inputs.
CryZe
force-pushed
the
allow-invalid-inputs
branch
from
47f9efc to
e88735c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently React behaves differently from Dioxus in that it doesn't allow changing inputs if they don't affect the value that they are bound to. So I spent some time on implementing some proper validation logic for the color inputs.