Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blurry image on mobile devices (especially in fullscreen mode) #49

Merged

Conversation

Tsar
Copy link
Contributor

@Tsar Tsar commented May 20, 2023

Fix canvas.width and canvas.height for mobile devices.

When you go fullscreen without this fix, meta content="width=1900" stops working and image becomes awfully blurry and low resolution. Similar effect is also a bit visible in landscape orientation without fullscreen mode (when 1900 is not enough).

Examples:

Without fix
1_before

With fix
1_after

Without fix
2_before

With fix
2_after

@wada-at-live2d-com wada-at-live2d-com self-assigned this May 24, 2023
@wada-at-live2d-com
Copy link
Contributor

@Tsar

Thank you for pull request and investigation!

This is a good change! I will check back soon to determine if this change can be incorporated.

@wada-at-live2d-com
Copy link
Contributor

@Tsar

Now that we have verified the correct behavior and the legitimacy of the code, we merge the PRs.

Thank you!

@wada-at-live2d-com wada-at-live2d-com merged commit 2526bb8 into Live2D:develop May 30, 2023
@Tsar Tsar deleted the fix/fix_blurry_image_on_mobile_devices branch May 30, 2023 09:39
@Tsar
Copy link
Contributor Author

Tsar commented May 30, 2023

Cool!
I'm happy to see that it made it's way to the repository.
Probably will bring some more soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants