Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/avoid namespace #34

Merged

Conversation

cocor-au-lait
Copy link
Contributor

This PR reflects the changes in Live2D/CubismWebFramework#3 and simplified import syntax in Samples.

I've confirmed that build process and the preview in Google Chrome work properly.

@wada-at-live2d-com
Copy link
Contributor

@cocor-au-lait
Thank you for pull request and investigation!
Sorry for the late reply.

This change will be very helpful in simplifying the code.

Please wait a while as we will check it in our environment as well.

Sincerely,

@wada-at-live2d-com
Copy link
Contributor

@cocor-au-lait

We have confirmed this changes made in this pull request, and will add and merge CHANGELOG.
Thank you for your report!

Sincerely,

@wada-at-live2d-com wada-at-live2d-com merged commit 2a6e811 into Live2D:develop Mar 2, 2021
@cocor-au-lait cocor-au-lait deleted the feature/avoid-namespace branch March 6, 2021 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants