Feat: Multi-language support #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for networking-toolbox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR implements multi-language support for the application, addressing feature requests #11 and #24. The implementation adds a comprehensive i18n system with English and German translations, language detection, and translation management infrastructure.
Key Changes
- Custom lightweight i18n system with translation loading and interpolation
- Language detection from localStorage, URL path, browser settings, or default
- English (en) and German (de) translation files for tools, settings, navigation, diagnostics, and common UI elements
- Translation validation scripts and NPM commands for checking translations
Reviewed Changes
Copilot reviewed 75 out of 341 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib/i18n/index.ts | Core i18n engine with translation lookup, interpolation, and pluralization |
| src/lib/i18n/lang-detector.ts | Language detection logic with fallback chain (localStorage → URL → browser → default) |
| src/lib/i18n/supported-languages.ts | Language configuration including ISO codes, native names, and flag emojis |
| src/lib/i18n/translations/en/*.json | English translation files for all UI sections |
| src/lib/i18n/translations/de/*.json | German translation files mirroring English structure |
| src/lib/components/tools/*.svelte | Component updates to use translation functions |
| package.json | Added i18n validation scripts and tsx dependency |
| playwright.config.ts | Increased webServer timeout from 120s to 180s |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will implement internationalization.
As requested in #11 and #24.
It's still a work-in-progress, and there's a fair amount left to do. So, stay-tuned for updates.