Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem deleting spaces #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

edelvalle
Copy link

When executing the spaces at the beginning of the first line of the selection where gone.
Also spaces at the beginning of the last line of selection still there, and should be removed.
I made kind of a macro, which is also a but easier to reason about.

After making this PR and seeing that the version changed, I did some digging and found that the main repo is here: https://github.com/micro-editor/updated-plugins/tree/master/join-lines-plugin

How can we push this change there? Do I have to do a PR there? or you as maintainer do it?

Kind regards and stay inside.

@Lisiadito
Copy link
Owner

Hi @edelvalle thanks for the PR. I will take a look at it.
The situation at the moment is this is the main repo for the plugin which can be used it micro v1 but I actually broke it by importing the utf8 golang package which is possible in micro v2 but I'm not sure how to do it in v1.
Additionally when this is fixed I need to make a PR for https://github.com/micro-editor/updated-plugins/blob/master/join-lines-plugin/repo.json to get to point to my newest release.
The author of micro made the updated-plugins repo for backwards compatibility since the plugin structure is a bit different for plugins for v1 and v2.
At the moment I'm considering dropping the support for v1 since it makes a lot of things easier. And as far as I can see your changes are as well only compatible with micro v2

@totoroot
Copy link

Hey @Lisiadito,

I found your helpful plugin and installed it. Thanks for creating this!
I stumbled over this issue as well. Any update on this?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants